Skip to content

#1806 Fix AT readout of botCreationDialog secret buttons #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2019
Merged

#1806 Fix AT readout of botCreationDialog secret buttons #1921

merged 3 commits into from
Oct 9, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Oct 9, 2019 •
edited
Loading

#1806

image

Various minor fixes

  • Adds an aria-label "Bot encryption key" to the secret's textfield
  • Changes placeholder text (which is read by the AT) to read "Your keys are not encrypted", encryptKeys boolean is true
  • adds aria-label to the <TextField> component.
  • Styling fixes for the Hide Secret and Copy Secret buttons, which also fixes the way the AT reads both buttons out in browse mode

@coveralls
Copy link

coveralls commented Oct 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 66.897% when pulling 3b48994 on corinagum/1806 into 2a14fe6 on master.

tonyanziano
tonyanziano suggested changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Also thanks for the styling fix, that was driving me crazy but never got around to it 😅

Had one suggestion.

tonyanziano
tonyanziano approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once CI goes green 👍

@corinagum corinagum merged commit 4ec726f into master Oct 9, 2019
@tonyanziano tonyanziano deleted the corinagum/1806 branch October 22, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@cwhitten cwhitten Awaiting requested review from cwhitten

1 more reviewer

@tonyanziano tonyanziano tonyanziano approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corinagum @coveralls @tonyanziano