Skip to content

#1806 Fix AT readout of botCreationDialog secret buttons #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2019
Merged

#1806 Fix AT readout of botCreationDialog secret buttons #1921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7faa02e
#1806 Fix AT readout of botCreationDialog
corinagum Oct 9, 2019
aecd6f8
Update CHANGELOG.md
corinagum Oct 9, 2019
3b48994
Update aria-label and placeholder text
corinagum Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1916](https://github.com/microsoft/BotFramework-Emulator/pull/1916)
- [1917](https://github.com/microsoft/BotFramework-Emulator/pull/1917)
- [1918](https://github.com/microsoft/BotFramework-Emulator/pull/1918)
- [1921](https://github.com/microsoft/BotFramework-Emulator/pull/1921)

- [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)
- [client] Implemented HTML app menu for Windows in PR [1893](https://github.com/microsoft/BotFramework-Emulator/pull/1893)
Expand Down
10 changes: 8 additions & 2 deletions packages/app/client/src/ui/dialogs/botCreationDialog/botCreationDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,12 @@ export class BotCreationDialog extends React.Component<BotCreationDialogProps, B
</Row>
<Row align={RowAlignment.Bottom} justify={RowJustification.Left}>
<TextField
aria-label="Bot encryption key"
inputContainerClassName={dialogStyles.key}
inputRef={this.setSecretInputRef}
label="Secret "
value={secret}
placeholder="Your keys are not encrypted"
placeholder={encryptKey ? '' : 'Your keys are not encrypted'}
disabled={true}
id="key-input"
type={revealSecret ? 'text' : 'password'}
Expand All @@ -208,7 +209,12 @@ export class BotCreationDialog extends React.Component<BotCreationDialogProps, B
</LinkButton>
</li>
<li>
<LinkButton className={dialogStyles.dialogLink} disabled={!encryptKey} onClick={this.onCopyClick}>
<LinkButton
ariaLabel="Copy secret"
className={dialogStyles.dialogLink}
disabled={!encryptKey}
onClick={this.onCopyClick}
>
Copy
</LinkButton>
</li>
Expand Down
3 changes: 2 additions & 1 deletion packages/app/client/src/ui/dialogs/dialogStyles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,10 @@
}

.actions-list {
display: flex;
list-style: none;
padding: 0;
margin: 0 0 15px 0;
margin: 0 0 10px 0;

li {
display: inline;
Expand Down