Skip to content

CI test with DefinitelyTyped #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschanaz opened this issue Mar 10, 2018 · 3 comments · May be fixed by #1039
Open

CI test with DefinitelyTyped #389

saschanaz opened this issue Mar 10, 2018 · 3 comments · May be fixed by #1039

Comments

@saschanaz
Copy link
Contributor

Sometimes compatibility with DefinitelyTyped breaks, a test will be great to prevent this.

@saschanaz
Copy link
Contributor Author

saschanaz commented Mar 14, 2018

Currently I think the CI script may do:

  1. Download DefinitelyTyped in ./DefinitlyTyped/ and do npm install there which will install a new TypeScript copy
  2. Replace ./DefinitelyTyped/node_modules/typescript/lib.dom.d.ts and lib.dom.iterable.d.ts with the new generated ones
  3. Do npm test in ./DefinitelyTyped.

@mhegazy
Copy link
Contributor

mhegazy commented Mar 23, 2018

Running all tests on DT takes a while. we do have a nightly test running on DT that catches issues once they make it to the nightly build.
You can also manually run the tests using the DT test runner in the main ts repo.

@saschanaz
Copy link
Contributor Author

saschanaz commented Mar 24, 2018

A manual test is always possible, but that still allows accidental merging of erroneous PRs. Also, it's not very easy for every contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants