Skip to content

Add DefinitelyTyped tests to CI #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Add DefinitelyTyped tests to CI #1039

wants to merge 19 commits into from
+66 −0

Conversation

orta
Copy link
Contributor

@orta orta commented Jul 2, 2021

Fixes #389

@orta
Try tests on DT

Verified

This commit was signed with the committer’s verified signature.
dianqk dianqk
SSH Key Fingerprint: r02VqMIyNff/fA8cMtZ1OQRglpsLIE0oa2RaM50dGHE
Verified
Learn about vigilant mode
a5ad86e
@orta orta requested a review from sandersn as a code owner July 2, 2021 16:11
@orta orta mentioned this pull request Jul 3, 2021
Closed
orta added 2 commits July 6, 2021 09:20
@orta
Merge branch 'main' into try_dt_tests

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
eb52ca5
@orta
Logs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
fc21c6d
sandersn
sandersn reviewed Jul 6, 2021
View reviewed changes
orta added 11 commits July 8, 2021 17:28
@orta
Yarn

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
881afb5
@orta
Moves the generated dom into the TS node_module

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
e53349c
@orta
Log version

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
e0a7a6e
@orta
Use my 4.3 branch of DT tools
d3ca587
@orta
Checkout origin
0870e8e
@orta
Checkout the right place
2aaf12e
@orta
Use the npm version of dtslint-runner
151fa35
@orta
Log the dtslint logs on CI
55e89c3
@orta
use 1 index
daea349
@orta
matrix
65dc808
@orta
Shards
d382107
@orta
Copy link
Contributor Author

orta commented Jul 8, 2021

This is close now

sandersn
sandersn previously approved these changes Jul 9, 2021
View reviewed changes
Bashamega
Bashamega reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@Bashamega Bashamega left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to me

@github-actions GitHub Actions
Copy link
Contributor

Sorry @Bashamega, you don't have access to these files:

@Bashamega
Copy link
Contributor

Hello @saschanaz, I think this might have slipped through your inbox. I believe this would be a great addition!

@Bashamega Bashamega mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn

+1 more reviewer

@Bashamega Bashamega

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI test with DefinitelyTyped
3 participants
@orta @Bashamega @sandersn