Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Add readonly for React Props interface #1322

Closed
wants to merge 1 commit into from

Conversation

xiaoxiangmoe
Copy link

@xiaoxiangmoe xiaoxiangmoe commented May 6, 2020

@orta
Copy link
Contributor

orta commented May 6, 2020

Yeah, that seems like a good call 👍

@swyxio
Copy link

swyxio commented May 7, 2020

fwiw i think a year ago @ferdaber said that the readonly is going to be applied from the @types/react side - not sure if that actually happened

@ferdaber
Copy link

ferdaber commented May 7, 2020

For class components I believe they are already read only.

@xiaoxiangmoe
Copy link
Author

For function component, readonly is needed.

What should I do now?

@ferdaber
Copy link

this PR is probably fine as-is, the updates on the React typings side can come later.

@orta
Copy link
Contributor

orta commented May 11, 2020

I'm not merging any PRs on this repo (content is frozen in preparation for archiving - see #1313) but when we flip the switch, I'll port over PRs to the v2 site

So for now, you can do nothing

@orta
Copy link
Contributor

orta commented Aug 1, 2020

These two tutorials now redirect to the typescript pages on the tool's side - so I can't reapply any of this to the v2 site. Thanks for the PR though!

@orta orta closed this Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants