[Advanced] Add readonly for React Props interface

[xiaoxiangmoe]

see https://reactjs.org/docs/components-and-props.html#props-are-read-only

related pr: microsoft/TypeScript-Handbook#1322

[swyxio]

ah we discussed this one before. fwiw i think a year ago @ferdaber said that the readonly is going to be applied from the @types/react side - not sure if that actually happened.

personally i dont think this is a huge deal.

[xiaoxiangmoe]

@sw-yx Do you mind if I create a PR to add readonly to Props?

[swyxio]

@xiaoxiangmoe can you add it as just a suggestion? i dont think it should be the default recommendation as it is not always needed.

[allan2]

@sw-yx Props are indeed read-only though. It would make sense for it to be the default since it is always the case.

[swyxio]

I understand. I personally don't like to do it but am happy to mention it as an option. 🤷‍♂️

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

[swyxio]

happy to take a PR but personally I won't be recommending specifying readonly for props.