Fix issue with JSX attribute names not being colorized in VS #570
Conversation
|
Hi, |
|
|
||
| - scope: meta.tag string.quoted, meta.tag string.quoted punctuation.definition.string, meta.tag string.quoted constant.character.escape | ||
| settings: { vsclassificationtype: xml literal - attribute value } |
There was a problem hiding this comment.
You would also want to do this in TypeScriptReact.Yaml-tmTheme
There was a problem hiding this comment.
I wasn't sure what those scopes apply to, so I didn't want to risk making something worse as nobody is complaining about anything other than the attribute name.
There was a problem hiding this comment.
I disagree. https://github.com/Microsoft/TypeScript-TmLanguage/blob/master/TypeScriptReact.YAML-tmTheme#L11 has attribute value which you changed in this PR to HTML Attribute Value, you want to do same on that line. I also think we should change the { vsclassificationtype: xml literal - text } part as well since we changed everything else to HTML. this is just incomplete change.
There was a problem hiding this comment.
Is there any way to change the color? (now JSX attrs have same color as the HTML tags and it's not good, tags are different from attributes)
| @@ -0,0 +1,974 @@ | |||
| { | |||
There was a problem hiding this comment.
Do not checking package-lock.json as its not related to this change.
There was a problem hiding this comment.
It's a whitespace only change (line endings probably). There is no change that would impact anything.
There was a problem hiding this comment.
This file wasnt added to git repo earlier and is being added as part of your change.
There was a problem hiding this comment.
Then it was correct to add it (https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5).
Fixes the issue discussed at https://developercommunity.visualstudio.com/content/problem/37434/jsx-attribute-no-longer-highlighted-in-dark-theme.html .
Note that tests were giving me massive failures on a fresh clone before any changes at all, so I'm just going to assume these are existing issues from out of date tests.
CC @mhegazy