Skip to content

Fix issue with JSX attribute names not being colorized in VS #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Fix issue with JSX attribute names not being colorized in VS #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions TypeScript.YAML-tmTheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ settings:
settings: { vsclassificationtype: identifier }

- scope: entity.name.tag
settings: { vsclassificationtype: xml literal - name }
settings: { vsclassificationtype: HTML Element Name }

- scope: entity.other.attribute-name
settings: { vsclassificationtype: XML Attribute }
settings: { vsclassificationtype: HTML Attribute Name }

- scope: meta.tag string.quoted, meta.tag string.quoted punctuation.definition.string, meta.tag string.quoted constant.character.escape
settings: { vsclassificationtype: xml literal - attribute value }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would also want to do this in TypeScriptReact.Yaml-tmTheme

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what those scopes apply to, so I didn't want to risk making something worse as nobody is complaining about anything other than the attribute name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. https://github.com/Microsoft/TypeScript-TmLanguage/blob/master/TypeScriptReact.YAML-tmTheme#L11 has attribute value which you changed in this PR to HTML Attribute Value, you want to do same on that line. I also think we should change the { vsclassificationtype: xml literal - text } part as well since we changed everything else to HTML. this is just incomplete change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to change the color? (now JSX attrs have same color as the HTML tags and it's not good, tags are different from attributes)

settings: { vsclassificationtype: HTML Attribute Value }
...
6 changes: 3 additions & 3 deletions TypeScript.tmTheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
<key>settings</key>
<dict>
<key>vsclassificationtype</key>
<string>xml literal - name</string>
<string>HTML Element Name</string>
</dict>
</dict>
<dict>
Expand All @@ -167,7 +167,7 @@
<key>settings</key>
<dict>
<key>vsclassificationtype</key>
<string>XML Attribute</string>
<string>HTML Attribute Name</string>
</dict>
</dict>
<dict>
Expand All @@ -176,7 +176,7 @@
<key>settings</key>
<dict>
<key>vsclassificationtype</key>
<string>xml literal - attribute value</string>
<string>HTML Attribute Value</string>
</dict>
</dict>
</array>
Expand Down
6 changes: 3 additions & 3 deletions TypeScriptReact.tmTheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
<key>settings</key>
<dict>
<key>vsclassificationtype</key>
<string>xml literal - name</string>
<string>HTML Element Name</string>
</dict>
</dict>
<dict>
Expand All @@ -167,7 +167,7 @@
<key>settings</key>
<dict>
<key>vsclassificationtype</key>
<string>XML Attribute</string>
<string>HTML Attribute Name</string>
</dict>
</dict>
<dict>
Expand All @@ -176,7 +176,7 @@
<key>settings</key>
<dict>
<key>vsclassificationtype</key>
<string>xml literal - attribute value</string>
<string>HTML Attribute Value</string>
</dict>
</dict>
<dict>
Expand Down
Loading