Skip to content

Handle scoped package resolution from custom type roots #53154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sheetalkamat opened this issue Mar 7, 2023 · 1 comment · Fixed by #53166
Closed

Handle scoped package resolution from custom type roots #53154

sheetalkamat opened this issue Mar 7, 2023 · 1 comment · Fixed by #53166
Assignees

Comments

@sheetalkamat
Copy link
Member

tldraw/tldraw

13 of 20 projects failed to build with the old tsc and were ignored

packages/vec/tsconfig.build.json

packages/vec/tsconfig.dev.json

packages/intersect/tsconfig.build.json

packages/intersect/tsconfig.dev.json

packages/curve/tsconfig.build.json

packages/curve/tsconfig.dev.json

packages/curve/tsconfig.json

This one needs further fixing. If looking into node_modules/@types we need to handle scoped package names.

image

Originally posted by @sheetalkamat in #53122 (comment)

@sheetalkamat sheetalkamat self-assigned this Mar 7, 2023
@sheetalkamat
Copy link
Member Author

sheetalkamat commented Mar 8, 2023

This also needs to update typeRoots to: ["node_modules/@types", "node_modules"]
https://github.com/tldraw/tldraw/blob/main/tsconfig.base.json#L31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant