update FormData interface on lib.d.ts #1592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complete FormData interface definition based on spec below. https://xhr.spec.whatwg.org/#formdata FYI, after tsc 1.4, it seems need to be update using USVString or FormDataEntryValue instead of string or any.
|
Thanks for the PR, and sorry for the late reply. This file is a result of a build, so in general you do not want to change the files in bin without changing the sources that generated them, as the next update to bin from a build will overwrite the changes. The source file contributing the FormData definition is src\lib\dom.generated.d.ts. This file is as well auto generated. We generated the dom from IE's dom specifications. this makes it really easy for us to generated updated dom definitions. but it also makes it hard for hand editing it. we are looking into changing the process and making this file generated from a webidl definitions. this is however not in the immediate plan. Is there an issue for the original issue? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complete FormData interface definition based on spec below.
https://xhr.spec.whatwg.org/#formdata
FYI, after tsc 1.4, it seems need to be update using USVString or FormDataEntryValue
instead of string or any.