Skip to content

Fixes #1618: "getElementsByTagName('svg')" does not returns NodeList of SVGSVGElement, but generic NodeList. #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jsakamoto
Copy link

Fixes #1618

@mhegazy
Copy link
Contributor

mhegazy commented Jan 8, 2015

Thanks for the PR. This file is a result of a build, so in general you do not want to change the files in bin without changing the sources that generated them, as the next update to bin from a build will overwrite the changes. (copied from reply to PR #1592)

These overloads are auto-generated into src\lib\dom.generated.d.ts from IE's dom specifications. this makes it really easy for us to generated updated dom definitions. but it also makes it hard for hand editing it. we are looking into changing the process and making this file generated from a webidl definitions. this is however not in the immediate plan.

For this change, I can update the script that generates theses to add the svg overload.

@mhegazy mhegazy closed this Jan 8, 2015
@danquirk danquirk added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Revisit An issue worth coming back to labels Jan 8, 2015
@jsakamoto
Copy link
Author

Thank you for your reply.

Wow, it is a result of a build.
It is my mistake, and exposes a lack of my understanding about the building process.

I understand it now, and I know the issue #1618 is assigned @mhegazy.
Thank you very much!

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Revisit An issue worth coming back to
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"getElementsByTagName('svg')" does not returns NodeList of SVGSVGElement, but generic NodeList.
3 participants