Do not emit code for @extends tags in JS.

[mprobst]

When transpiling JavaScript, TS3.1+ emits @extends tags as code. E.g.

/** @extends {SuperClass} */
class SubClass {}

Causes an ES5 emit that references SuperClass:

/**
* @extends {SomeBase}
*/
var SubClass = /** @class */ (function (_super) {
    __extends(SubClass, _super);
    function SubClass() {
        return _super !== null && _super.apply(this, arguments) || this;
    }
    return SubClass;
}(SomeBase));

Note the literal references to SomeBase.

This appears to be an accidental effect of
0f55566. It refactored
getEffectiveBaseTypeNode for type checking, but missed an instance
where it is also used for emit logic. This change fixes the problem by
specifically getting the heritage clauses directly off the AST.

[mprobst]

/CC @sandersn

[weswigham]

@mprobst you'll find the tests easier to write/baseline if you add a compiler test instead of a project test (I don't think we ever really add new project tests much anymore). Something like

// @outDir: ./out
// @allowJs: true
// @filename: extends.js
/** @extends {SuperClass} */
class SubClass {}

should work.

[mprobst]

@weswigham thanks! I'll take a look at that tomorrow.

I don't understand my test failure, locally npm test passes. Maybe a Windows vs Linux issue? Any idea?

[weswigham]

I would guess it's failing because your input file, tests/cases/projects/jsFileCompilation/ExtendsTag/extends.js, isn't actually in the PR 😄

[weswigham]

You definitely want to write a compiler test instead, however 😉

[mprobst]

💡 .gitignore caused the file to be ignored, silently.

For context, I was looking for tests that used *.js and only found the projects cases, didn't realize @filename was the thing to look for.

I've moved to a compiler test case, that's indeed much simpler.