-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Exclude JSDoc @extends from 'super()' checks #29308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes a similar problem as microsoft#29244 where JSDoc `@extends`
@ajafff I think this bug needs more discussion; /** @extends {Array<number>} */
class Numbers extends Array {
} I think the extends jsdoc should be ignored unless it has a matching extends clause. That would mean a change to getEffectiveBaseTypeNode to only return getJSDocAugmentTag if that tag has a matching extends clause. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more discussion of the bug and how to fix it.
@sandersn I think that's different from the changes in this PR. In a follow-up PR |
@ajafff you are right, I read the intent of the change backward and now that you added the error on referencing |
* origin/master: (1082 commits) Fix unneeded cast lints (microsoft#29383) Extracted compilerOptions setting to helper function Added codefix to enable experimentalDecorators in the user's config file Add tests for noLib with <reference lib> and bundling. Add tests for noLib with <reference lib>. Do not process library reference directives with noLib set. emit jsx type arguments Allow circular umd-merged-with-augmentation refs to resolve to the module as intended (microsoft#29335) Allow nonnull assertions in references (microsoft#29351) Accept new baselines Add regression tests Improve logic that determines when to resolve conditional types Update user baselines (microsoft#29336) Fix crash (microsoft#29333) Exclude JSDoc @extends from 'super()' checks (microsoft#29308) Fix existing test Verify that completion with new identifier location returns isNewIdentifierLocation: true Fixes microsoft#24009 Fix the failing test case There is no need to check for file presence when trying to rename imports based on file rename Fixes microsoft#29031 Fix gulp baseline-accept (microsoft#29301) ...
This fixes a similar problem as #29244 where JSDoc
@extends
is treated asclass X extends