Handle shebang, emit helpers, prologues and triple slash refs in prepend nodes #29582
Conversation
sheetalkamat
requested review from
rbuckton,
weswigham,
RyanCavanaugh and
sandersn
| // Helpers | ||
| let helpers: UnscopedEmitHelpers[] | undefined; | ||
| while (true) { | ||
| const helperInfo = tryGetUnscopedEmitHelper(text, pos); |
There was a problem hiding this comment.
Should we even be scanning for helpers or prologues if the source type is a "dts"? Likewise, should we bother scanning for triple slash directives in "js"?
There was a problem hiding this comment.
I guess we can but we need to make a note that if some such future common header like functionality needs to be added to consider both emits since emitter doesn't distinguish these concepts between dts or js and goes with transformed nodes.
There was a problem hiding this comment.
Hmm, doesn't that imply that the factory function should just take the nodes/fields as children and that there should be parser helpers for fetching them from the text (rather than the factory function automatically producing them itself)?
|
Closing this in favor of #29630 |
Fixes #25550