-
Notifications
You must be signed in to change notification settings - Fork 12.8k
For composite projects with --out write tsbundleInfo file and use it to process shebang, prologues and other information #29630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
07a8400
to
0aaa880
Compare
@sheetalkamat Could we have both methods of looking up the metadata in place? The bundle info is nice for build pipelines that only use |
@weswigham we are call host.readFile and host.writeFile so any kind of build chains should have no issues with this right? Wouldnt we want host to implement those details. Having second method of retrival is easy but that just adds another code path we need to maintain and test. Is it really necessary? |
@sheetalkamat I'm thinking more along the lines of build chains that just shell out to |
@weswigham I had chat with @RyanCavanaugh and we think at this moment the fall back parsing isn't necessary. |
9289109
to
bb76259
Compare
I am going to close this and open PR that is bigger set of changes where prepend mapping works much better. |
This is another version of #29582 and would be helpful to enable --stripInternal by recording those sections and not emitting those portions on final projects with --stripInternal (eg. generating typescript.d.ts)
Fixes #25550