Format on type deletes valid range

[dbaeumer]

Type enter on a line and the result is totally unexpected.
File (Game.ts):
///
///
///
module Mankala {
export var NoSpace = -1;
export var homeSpaces = [[0,1,2, 3, 4, 5],
[7,8,9,10,11,12]];
export var firstHomeSpace = [0,7];
export var lastHomeSpace = [5,12];
export var capturedSpaces = [12,11,10,9,8,7,NoSpace,5,4,3,2,1,0,NoSpace];
export var NoScore = 31;
export var NoMove = -1;
}
Press enter after " [7,8,9,10,11,12]];"

The result is super weird, see screenshot:

The problem is in

                        else if (indentPosition < 0) {
                            edits.push({
                                span: ts.createTextSpanFromBounds(position, position - indentPosition),
                                newText: ""
                            });

IndentPosition is negative so we delete characters form the current position on forward.

The pull request fixes this plus handles the fact that existing indent uses tabs. The problem here is that indentPosition counts the column. But on removal one column doesn't equal one character to remove since \t counts for n columns.

[CyrusNajmabadi]

Why is this changing as part of a formatting change?

[mhegazy]

I agree this needs to be in a separate change.

[vladima]

agree

[mhegazy]

@vladima can you take a look?

[DanielRosenwasser]

else on the next line

[mhegazy]

@dbaeumer what is the status of this change?

[mhegazy]

@dbaeumer looks like the indentation issue has been fixed. we can not get it to repro on latest VS or VS Code. for the buffer issue can you please resubmit?

[dbaeumer]

OK. I tested it and the issue seems to be fixed in the underlying formatting code. However I still believe that there are issues in the code as soon as the correction code is hit.

                        else if (indentPosition < 0) {
                            edits.push({
                                span: ts.createTextSpanFromBounds(position, position - indentPosition),
                                newText: ""
                            });
                        }

This part of the code will delete text from the position to the right (indentPosition is negative and so position - indentPosition > position.

In addition the code doesn't handle the tabs setting correctly since it always generates spaces for extra indent. I opened #3681 for this.

[dbaeumer]

And sorry for the writeSync issue. I opened a separate pull request here:

Node System host write - need to loop since writeSync might not write all bytes in one request #3682