DialogContext: tactical change to decouple from TurnContext to remediate breaking changes #4860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate breaking changes
…rete implementation.
carlosscastro
commented
Oct 23, 2020
| { | ||
| var locale = ((TurnContext)Context).Locale ?? null; | ||
| return locale; | ||
| return Context.TurnState.Get<string>("turn.locale"); |
There was a problem hiding this comment.
Note that this string is defined in TurnContext. However the goal is to deprecate the GetLocale() method in a future PR, so I don't want to make the constant in TurnContext public just to deprecate it. This coupling should never have happened unfortunately :(
johnataylor
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4657
Unfortunately we broke developers who implemented their own
ITurnContextwhen adding a cast toTurnContextinDialogContext.GetLocale(). Furthermore, theGetLocale()method is quite useless considering that whenever theDialogContextis available, aITurnContextinstance is available as well and we could get the locale from there.I have some broader locale changes in another incoming PR (in which I mark
DialogContext.GetLocale()as deprecated among other things), but this is the minimum bar, which is to un-break developers that have been broken because of this change.