Skip to content

[PORT] DialogContext: tactical change to decouple from TurnContext to remediate breaking changes #3041

@chon219

Description

@chon219

microsoft/botbuilder-dotnet#4860

Unfortunately we broke developers who implemented their own ITurnContext when adding a cast to TurnContext in DialogContext.GetLocale(). Furthermore, the GetLocale() method is quite useless considering that whenever the DialogContext is available, a ITurnContext instance is available as well and we could get the locale from there.

I have some broader locale changes in another incoming PR (in which I mark DialogContext.GetLocale() as deprecated among other things), but this is the minimum bar, which is to un-break developers that have been broken because of this change.

Metadata

Metadata

Assignees

Labels

Area: SDKGeneral SDK issues that don't clearly map to other areas (e.g.: helper methods)

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions