This repository was archived by the owner on Mar 4, 2020. It is now read-only.
breaking(Button): replace type prop with secondary and primary
#419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
- Coverage 91.77% 91.76% -0.01%
==========================================
Files 41 41
Lines 1325 1324 -1
Branches 169 168 -1
==========================================
- Hits 1216 1215 -1
Misses 105 105
Partials 4 4
Continue to review full report at Codecov.
|
bmdalex
suggested changes
Nov 2, 2018
layershifter
commented
Nov 2, 2018
| if (onClick) { | ||
| onClick(e, this.props) | ||
| } | ||
| _.invoke(this.props, 'onClick', e, this.props) |
There was a problem hiding this comment.
Simplify with invoke()
layershifter
force-pushed
the
breaking/button-type
branch
2 times, most recently
from
d7739a3 to
a44b20c
Compare
layershifter
force-pushed
the
breaking/button-type
branch
from
a44b20c to
b5428b5
Compare
miroslavstastny
approved these changes
Nov 2, 2018
miroslavstastny
suggested changes
Nov 2, 2018
CHANGELOG.md
Outdated
| @@ -19,6 +19,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
| ### Fixes | |||
| - Fix endMedia to not be removed from DOM on mouseleave for `ListItem` @musingh1 ([#278](https://github.com/stardust-ui/react/pull/278)) | |||
| - Replace the `type` prop with `secondary` and `primary` for `Button` @layershifter ([#419](https://github.com/stardust-ui/react/pull/419)) | |||
There was a problem hiding this comment.
This should go to BREAKING CHANGES!
bmdalex
approved these changes
Nov 2, 2018
layershifter
force-pushed
the
breaking/button-type
branch
from
8efcb8c to
2affefa
Compare
|
agreed with @miroslavstastny |
miroslavstastny
approved these changes
Nov 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374, please refer there to get more details.