This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Button): make primary & secondary props mutually exclusive
#431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
miroslavstastny
approved these changes
Nov 5, 2018
CHANGELOG.md
Outdated
| @@ -23,6 +23,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
|
|
|||
| ### Fixes | |||
| - Fix endMedia to not be removed from DOM on mouseleave for `ListItem` @musingh1 ([#278](https://github.com/stardust-ui/react/pull/278)) | |||
| - Make `secondary` and `primary` props mutually exclusive for `Button` @layershifter ([#429](https://github.com/stardust-ui/react/pull/429)) | |||
There was a problem hiding this comment.
I would omit this in changelog as the Unreleased version is the one which introduces #419.
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 41 41
Lines 1337 1337
Branches 168 193 +25
=======================================
Hits 1228 1228
Misses 105 105
Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #419.
This PR makes
primary&secondaryprops mutually exclusive like in #429.