[BUG] Can't register custom selectors using sync API

[trogowski]

Context:

• Playwright Version: 1.22.0
• Operating System: Windows 11
• Python version: 3.10.2
• Browser: Chromium
• Extra: PDM version 1.14.1

Code Snippet

from playwright.sync_api import sync_playwright as pw

max_length_selector = """
    {
      query(root, selector) {
        return root.querySelector(`[maxlength="${selector}"]`);
      },
      queryAll(root, selector) {
        return Array.from(root.querySelectorAll(`[maxlength="${selector}"]`));
      }
    }"""

with pw() as p:
    selectors = p.selectors
    selectors.register('max_length', max_length_selector)

    browser = p.chromium.launch(headless=False)
    page = browser.new_page()
    page.goto('https://google.com')

    search_button = page.locator('max_length=2048')
    print(search_button.count())

    browser.close()

Describe the bug

p.selectors property access throws following error:

Traceback (most recent call last):
  File "C:\x\dev\projects\sources\python-playground\web_scrapping\playwright_examples\07_custom_selector.py", line 18, in <module>
    selectors = p.selectors
  File "C:\x\dev\projects\sources\python-playground\web_scrapping\playwright_examples\__pypackages__\3.10\lib\playwright\sync_api\_generated.py", line 11939, in selectors
    return mapping.from_impl(self._impl_obj.selectors)
  File "C:\x\dev\projects\sources\python-playground\web_scrapping\playwright_examples\__pypackages__\3.10\lib\playwright\_impl\_impl_to_api_mapping.py", line 73, in from_impl
    result = self.from_maybe_impl(obj)
  File "C:\x\dev\projects\sources\python-playground\web_scrapping\playwright_examples\__pypackages__\3.10\lib\playwright\_impl\_impl_to_api_mapping.py", line 65, in from_maybe_impl
    api_instance = api_class(obj)
  File "C:\x\dev\projects\sources\python-playground\web_scrapping\playwright_examples\__pypackages__\3.10\lib\playwright\_impl\_sync_base.py", line 72, in __init__
    self._dispatcher_fiber = impl_obj._dispatcher_fiber
AttributeError: 'Selectors' object has no attribute '_dispatcher_fiber'

Here is the offending code in _sync_base.py

class SyncBase(ImplWrapper):
    def __init__(self, impl_obj: Any) -> None:
        super().__init__(impl_obj)
        self._loop: asyncio.AbstractEventLoop = impl_obj._loop
        self._dispatcher_fiber = impl_obj._dispatcher_fiber

The same example reimplemented using async API works fine.

[fj201314]

The synchronization API of the official case still seems to report the same error

[fj201314]

from playwright.sync_api import sync_playwright

def run(playwright):
tag_selector = """
{
// Returns the first element matching given selector in the root's subtree.
query(root, selector) {
return root.querySelector(selector);
},
// Returns all elements matching given selector in the root's subtree.
queryAll(root, selector) {
return Array.from(root.querySelectorAll(selector));
}
}"""

# Register the engine. Selectors will be prefixed with "tag=".
playwright.selectors.register("tag", tag_selector)
browser = playwright.chromium.launch()
page = browser.new_page()
page.set_content('<div><button>Click me</button></div>')

# Use the selector prefixed with its name.
button = page.locator('tag=button')
# Combine it with other selector engines.
page.locator('tag=div >> text="Click me"').click()
# Can use it in any methods supporting selectors.
button_count = page.locator('tag=button').count()
print(button_count)
browser.close()

with sync_playwright() as playwright:
run(playwright)

[fj201314]

Playwright Version: 1.22.0
Operating System: Windows 11
Python version: 3.8.10
Browser: Chromium

[fj201314]

But the asynchronous API is OK