fix: sync selectors #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mxschmitt merged 1 commit into microsoft:main from mxschmitt:fix-sync-selectors

May 26, 2022

Member

mxschmitt commented May 26, 2022

pass Playwright dispatching fiber down to the Selector class instance
port https://github.com/microsoft/playwright-python/blob/97c64908216aec0afe9d6a9a0277fecebc3b2ae3/tests/async/test_queryselector.py to the sync variant

Fixes #1324


          fix: sync selectors

293a6ad

rwoll approved these changes

View reviewed changes

Member

rwoll left a comment

LGTM—and thanks for porting the other tests!

mxschmitt merged commit 50fbc75 into microsoft:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet