Skip to content

test: fix WebKit tests #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2022
Merged

test: fix WebKit tests #1328

merged 2 commits into from
May 27, 2022

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented May 27, 2022 •
edited
Loading

We only run the tests on macOS 11+, so I don't keep the check for making them pass on macos10.15.

This fixes:

  • test_page_route_should_be_abortable_with_custom_error_codes[webkit]
  • test_page_route_should_fail_navigation_when_aborting_main_resource[webkit]

@mxschmitt mxschmitt merged commit 4ccde4a into microsoft:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @yury-s