Skip to content

test: fix WebKit tests #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2022
Merged

test: fix WebKit tests #1328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a1533d
test: fix WebKit tests
mxschmitt May 27, 2022
5601077
unflake websocket tests
mxschmitt May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/async/test_interception.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ async def test_page_route_should_be_abortable_with_custom_error_codes(
assert len(failed_requests) == 1
failed_request = failed_requests[0]
if is_webkit:
assert failed_request.failure == "Request intercepted"
assert failed_request.failure == "Blocked by Web Inspector"
elif is_firefox:
assert failed_request.failure == "NS_ERROR_OFFLINE"
else:
Expand All @@ -277,7 +277,7 @@ async def test_page_route_should_fail_navigation_when_aborting_main_resource(
await page.goto(server.EMPTY_PAGE)
assert exc
if is_webkit:
assert "Request intercepted" in exc.value.message
assert "Blocked by Web Inspector" in exc.value.message
elif is_firefox:
assert "NS_ERROR_FAILURE" in exc.value.message
else:
Expand Down
8 changes: 4 additions & 4 deletions tests/async/test_websocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,17 @@ def on_web_socket(ws):


async def test_should_emit_binary_frame_events(page, ws_server):
done_task = asyncio.Future()
sent = []
received = []

def on_web_socket(ws):
ws.on("framesent", lambda payload: sent.append(payload))
ws.on("framereceived", lambda payload: received.append(payload))
ws.on("close", lambda: done_task.set_result(None))

page.on("websocket", on_web_socket)
async with page.expect_event("websocket") as ws_info:
async with page.expect_event("websocket"):
await page.evaluate(
"""port => {
const ws = new WebSocket('ws://localhost:' + port + '/ws');
Expand All @@ -107,9 +109,7 @@ def on_web_socket(ws):
}""",
ws_server.PORT,
)
ws = await ws_info.value
if not ws.is_closed():
await ws.wait_for_event("close")
await done_task
assert sent == [b"\x00\x01\x02\x03\x04", "echo-bin"]
assert received == ["incoming", b"\x04\x02"]

Expand Down