Skip to content

feat(types): Use typing.Optional for Optional Types #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(types): Use typing.Optional for Optional Types #684

wants to merge 1 commit into from

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 12, 2021 •
edited
Loading

Ref #507

@kumaraditya303 kumaraditya303 marked this pull request as draft May 22, 2021 08:44
pavelfeldman
pavelfeldman reviewed May 25, 2021
View reviewed changes
playwright/async_api/_generated.py
@@ -885,9 +885,9 @@ async def down(

Parameters
----------
button : Union["left", "middle", "right", NoneType]
button : Optional["left", "middle", "right"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @pavelfeldman