Skip to content

Conversation

mxschmitt
Copy link
Member

The change which broke us in the NPM CLI was npm/cli#8185. I didn't find a better way to fix it, so disabling the rewrite for now. We probably would have to parse out the response in tests/installation/registry.ts:113 and rewrite the response body there to include the new registry URL.

#36404

@mxschmitt mxschmitt requested a review from Skn0tt June 25, 2025 09:18
@mxschmitt mxschmitt merged commit 4097023 into microsoft:main Jun 25, 2025
29 checks passed
@mxschmitt mxschmitt deleted the fix-itest-nodejs-24 branch June 25, 2025 09:52
Copy link
Contributor

Test results for "tests 1"

6 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39466 passed, 823 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants