Skip to content

test: fix installation tests under Node.js 24 #36434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

test: fix installation tests under Node.js 24 #36434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/installation/npmTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ export const test = _test
const npmLines = [
`registry = ${registry.url()}/`,
`cache = ${testInfo.outputPath('npm_cache')}`,
// Required after https://github.com/npm/cli/pull/8185.
'replace-registry-host=never',
];
if (!allowGlobalInstall) {
yarnLines.push(`prefix "${testInfo.outputPath('npm_global')}"`);
Expand Down
1 change: 0 additions & 1 deletion tests/installation/playwright-cli-install-should-work.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ test('install command should work', async ({ exec, checkInstalledSoftwareOnDisk

await test.step('playwright install --list', async () => {
const result = await exec('npx playwright install --list');
console.log('result', result);
expect.soft(result).toMatch(/Playwright version: \d+\.\d+/);
expect.soft(result).toMatch(/chromium-\d+/);
expect.soft(result).toMatch(/chromium_headless_shell-\d+/);
Expand Down
Loading