-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Squiggles missing for Python errors #9649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Please also let me know if I should file a bug report against the Language Server instead. |
You must be using pylint as linter. Use flake8. The latest update was supposed to fix linting but I've found that pylint is still not working with latest update but flake8 works. |
This regression would seem to have been introduced in 2020.1.57204. flake8 and bandit do seem to work normally in 2020.01.58038, as @sys-temd indicates. Reverting to 2019.11.50794 works around this. |
I am not using any linters:
Previously the Language Server itself would highlight errors without the need to enable linters, but this stopped working in recent versions. |
Similar to microsoft/python-language-server#1868? |
This looks like the same issue as microsoft/python-language-server#1868, but this is most likely not a parser bug (as microsoft/python-language-server#1868 is tagged). From my original post:
This sounds like a bug in the VS Code Python extension and not a bug in the language server itself. |
@rlee287 Try declaring |
That setting is already set as you suggested in my global config(you can look above at my If you mean |
Yeah, based on that error message this looks like the extension, maybe to do with the diagnostic middleware it uses, though I don't know why it'd be undefined. |
I'm going to transfer this back so the right people can handle this. https://github.com/microsoft/python-language-server/issues/1873#issuecomment-575460659 is the critical comment with the message, though the minified file makes it pretty difficult to determine which |
Yes. Create .vscode > settings.json in your workspace directory and declare |
Noting that creating the |
It seems that language server is not working at all. The above solution worked for enabling pylint: #9657 |
Hey @rlee287 |
@MikhailArkhipov @jakebailey Error This should've been fixed(?) in #9109 where we ensure that Any idea why we're still getting this error? |
Yes |
microsoft/python-language-server#1868 is a parser issue and is not related to |
For now, I have downgraded to 2019.11.50794, and I can confirm that squiggles work there. Has there been an update yet on fixing this issue? |
Hi everyone,
|
Thank ya @kimadeline |
@kimadeline do we have any estimate on when the newer version is coming? |
@mahmoudajawad It is fixed in 2020.2.63072 (12 February 2020). Update your extension. |
The latest version 2020.2.63072 fixes this issue for me, so I will close the issue accordingly. |
Environment data
pipenv
)"python.jediEnabled"
set to; more info How to update the language server to the latest stable version #3977): Language ServerExpected behaviour
Red/yellow squiggles appear when issues are found.
Actual behaviour
No squiggles appear.
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]
Open an empty folder in VS Code.
Create a new file (I called mine
example.py
)Type the following text into the file:
Screenshot of results:
(This issue is a regression (though I don't remember when it started happening) so if there is a way I can do a local version of
git bisect
to find the issue please let me know)Logs
Output for
Python
in theOutput
panel (View
→Output
, change the drop-down the upper-right of theOutput
panel toPython
)Output from
Python Language Server
in theOutput
panel:Output from
Console
under theDeveloper Tools
panel (toggle Developer Tools on underHelp
; turn on source maps to make any tracebacks be useful by runningEnable source map support for extension debugging
)Most likely the critical line in the above log is
Notification handler 'textDocument/publishDiagnostics' failed with message: Cannot read property 'connected' of undefined
fromconsole.ts:137
.The text was updated successfully, but these errors were encountered: