This repository was archived by the owner on Apr 14, 2022. It is now read-only.
On redefinition of function, give a diagnostic message #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there are a few more test cases you're going to want to write, things like: def foo():
def foo():
return 123
return foo()
foo()Nested classes, etc. |
|
Aha, thanks, I was wondering what kind of cases to test beyond this. |
jakebailey
reviewed
Jul 10, 2019
|
For testing:
|
|
Resolve conflicts and LGTM. |
jakebailey
approved these changes
Jul 15, 2019
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
* Doing preliminary function redefinition check, need to add testS * Fixing up error message and cleaning up code * Adding some light tests * Reordering * Adding some more tests on function redefinition * Switching to nicer syntax in SymbolCollector * Renaming test files * Adding redefined tests when importing as well * handling properties too * Switching to switch statement * Minor syntax change * Unused import * Switching type out for interface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, we skipped this one before because we were worried about collisions with imports, but the function definition code seems to only looks up functions in the local context - so it will only care about other functions declared in the same file as it.