This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Revert redefined function diagnostic #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
commented
Jul 22, 2019
| @@ -25,8 +25,6 @@ public static class ErrorCodes { | |||
| public const string UndefinedVariable = "undefined-variable"; | |||
| public const string VariableNotDefinedGlobally= "variable-not-defined-globally"; | |||
| public const string VariableNotDefinedNonLocal = "variable-not-defined-nonlocal"; | |||
| public const string FunctionRedefined = "function-redefined"; | |||
| public const string UnsupportedOperandType = "unsupported-operand-type"; | |||
There was a problem hiding this comment.
This was in #1273 but was a merge error there; removing it now too.
MikhailArkhipov
approved these changes
Jul 22, 2019
jakebailey
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1346.
Closes #1358.
This is too risky for now; without dataflow analysis and handling of odd cases like in #1358 (comment) this is probably too much to be there by default. Manual revert of #1273 (auto-revert had conflicts).