This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Fixing issue with decorators with same prefix seen as redefinition #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
reviewed
Jul 22, 2019
jakebailey
reviewed
Jul 22, 2019
| ReportRedefinedFunction(fd, existing as PythonType); | ||
| break; | ||
| // lambdas have the same function name, so don't count them as redefinitions | ||
| if (!string.IsNullOrEmpty(fd.Name) && !fd.IsLambda && !IsRedefinedByDecorator(fd)) { |
There was a problem hiding this comment.
On a second reading, I think it'd be best to do this:
if (existing != null
&& !fd.IsLambda
&& !string.IsNullOrEmpty(fd.Name)
&& !IsRedefinedByDecorator(fd)) {
switch (existing.MemberType) { }
}As for the most part, there aren't going to be any redefinitions, and existing will be null. As written now with the switch case's existing? check, the null check happens last, even though it's the most likely.
There was a problem hiding this comment.
Good insight, I'll add it.
|
Closing; see #1359. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed pylint's guide more closely.