Skip to content

Update isort and black in run_formatters script to Ruff #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Nov 10, 2024

Apparently I glanced over this file in previous PRs

I wouldn't really call "ruff check --fix" a formatter... Maybe I should rename the file to run_hygiene to match the CI job name ?

@Avasam Avasam force-pushed the Update-isort-and-black-in-run_formatters-script-to-Ruff branch from 7163e13 to 3b22754 Compare November 10, 2024 20:43
@Avasam Avasam force-pushed the Update-isort-and-black-in-run_formatters-script-to-Ruff branch from 3b22754 to 3581030 Compare January 28, 2025 20:46
Copy link
Contributor

@debonte debonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming to use "hygiene" instead of "format" sounds good to me.

@Avasam Avasam force-pushed the Update-isort-and-black-in-run_formatters-script-to-Ruff branch 2 times, most recently from 3b22754 to c360cc9 Compare January 30, 2025 04:03
@Avasam Avasam force-pushed the Update-isort-and-black-in-run_formatters-script-to-Ruff branch from 19edff9 to 597f811 Compare March 15, 2025 15:35
@Avasam Avasam force-pushed the Update-isort-and-black-in-run_formatters-script-to-Ruff branch from 597f811 to 281984e Compare March 15, 2025 15:36
@debonte debonte merged commit b3726b0 into microsoft:main Mar 25, 2025
3 checks passed
@Avasam Avasam deleted the Update-isort-and-black-in-run_formatters-script-to-Ruff branch March 26, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants