Fix macOS Alert API issues #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew." This reverts commit 5a67ae0.
markavitale
approved these changes
May 11, 2020
| { | ||
| key: 'AlertMacOSExample', | ||
| module: require('../examples/Alert/AlertMacOSExample'), | ||
| supportsTVOS: true, |
There was a problem hiding this comment.
ha. That's what it was before it was removed in the .61 merge. This will go away again after issue #354.
| } else { | ||
| callback(@[buttonKey]); | ||
| } | ||
| buttonKey = buttons[response - NSAlertFirstButtonReturn].allKeys.firstObject; |
There was a problem hiding this comment.
Is this copied from somewhere? We should probably get rid of the dot notation.
There was a problem hiding this comment.
When it was ported from the ios above years ago it assumed the same dot notation.
|
Nice additions to RNTester 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
The Alert API for macOS was broken:
alertcalls were showing an input field (only prompts should show an input field)defaultValuearg ofprompthas not being honoredAlertMacOSExamplewas lostalertandpromptwith a single button were not returning a JS callbackThe first two issues were recent regressions when merging from upstream. The last issue is old, possible since macOS Alert was first implemented, and discovered as I tested the macOS and iOS RNTester side by side.
Closes #353
In react-native there is the
AlertAPI that works for iOS and Android, but contains anoptionsargument with Android specific options.There is also an
AlertIOSwith iOS specific concerns but it is now deprecated.When macOS was first implemented we made an
AlertMacOSwith macOS specific concerns. Long term we should deprecate this and add the macOS concerns to theoptionsargument ofAlert.Issue #354 tracks deprecating
AlertMacOS.Changelog
[macOS] [Fixed] - Fix macOS Alert API issues
Test Plan
The RNTester
Alertand the newly restoredAlertMacOSpages where manually tested.Microsoft Reviewers: Open in CodeFlow