Integrate RN Nightly 9/20 #12165
Merged
Integrate RN Nightly 9/20 #12165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
reviewed
Oct 3, 2023
There was a problem hiding this comment.
There should really be a .gitignore in the e2e-test-app-fabric folder that prevents this bundle from being checked in.
jonthysell
reviewed
Oct 3, 2023
| @@ -177,8 +177,8 @@ void DeviceInfoHolder::updateDeviceInfo() noexcept { | |||
| } | |||
| } | |||
|
|
|||
| ReactNativeSpecs::DeviceInfoSpec_Constants DeviceInfo::GetConstants() noexcept { | |||
There was a problem hiding this comment.
Since we stub out this module in each Fabric app (e2e-test-app-fabric, playground-composition, and the cpp-app template), we need to apply this rename there too
jonthysell
approved these changes
Oct 4, 2023
…e it in our metro config
jonthysell
reviewed
Oct 5, 2023
.ado/templates/react-native-init.yml
Outdated
| @@ -89,6 +89,7 @@ steps: | |||
| - ${{ if eq(parameters.projectType, 'lib') }}: | |||
| - script: | | |||
| npx --yes [email protected] --package-name "testcli" testcli | |||
| rd /s /q testcli\android | |||
There was a problem hiding this comment.
This is necessary because this old create-react-native-module module now no longer creates working android code (as of this integrate), which prevents react-native config from running successfully, which breaks run-windows.
acoates-ms
approved these changes
Oct 5, 2023
YajurG
pushed a commit
to YajurG/react-native-windows
that referenced
this pull request
Oct 18, 2023
* Integrate 8/24 * Change files * Update Overrides * Update Metro * Update Packages * Change files * Update Snapshots * Update Pkg Version * Integrate 9/20 * Change files * Remove Override * Remove Override * Add Files to CICompile * Fix Build Break * Format + Overrides + Warnings Fix * Add Override * Address Feedback * Address Feedback * Try to fix missing-asset-registry-path error * Remove deleted yoga functions from exported def file * Force resolution of @react-native/[email protected] and actually use it in our metro config * Fix Snapshots * fix bundles * Fix lib cli-init * fix playground bundle again * Yarn * fix lib again * Fix Test --------- Co-authored-by: Jon Thysell <[email protected]> Co-authored-by: Andrew Coates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
What
facebook/react-native@68c7cfe...630cf3b
Relevant PRs:
Changelog
Should this change be included in the release notes: No
Microsoft Reviewers: Open in CodeFlow