Fix interval timer not firing causing cpptools to exit after 4 minutes #13469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmcmorran
approved these changes
Apr 7, 2025
Colengms
approved these changes
Apr 7, 2025
Colengms
approved these changes
Apr 8, 2025
|
It sounds like there might be some follow up changes as well to change how initialization and message registration are handled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing cpptools to exit after 4 minutes when it should not, which incorrectly leads to these messages appearing in the screenshot below, which can confuse users into thinking there's an unexpected bug, see for example #13465:
This moves the initialization of the interval timer earlier before it could get blocked by the
await this.onDidChangeVisibleTextEditors(cppEditors);.