Skip to content

Fix interval timer not firing causing cpptools to exit after 4 minutes #13469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Fix interval timer not firing causing cpptools to exit after 4 minutes #13469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ import * as configs from './configurations';
import { CopilotCompletionContextFeatures, CopilotCompletionContextProvider } from './copilotCompletionContextProvider';
import { DataBinding } from './dataBinding';
import { cachedEditorConfigSettings, getEditorConfigSettings } from './editorConfig';
import { CppSourceStr, clients, configPrefix, updateLanguageConfigurations, usesCrashHandler, watchForCrashes } from './extension';
import { CppSourceStr, clients, configPrefix, initializeIntervalTimer, updateLanguageConfigurations, usesCrashHandler, watchForCrashes } from './extension';
import { LocalizeStringParams, getLocaleId, getLocalizedString } from './localization';
import { PersistentFolderState, PersistentState, PersistentWorkspaceState } from './persistentState';
import { RequestCancelled, ServerCancelled, createProtocolFilter } from './protocolFilter';
Expand Down Expand Up @@ -1365,6 +1365,8 @@ export class DefaultClient implements Client {
// Listen for messages from the language server.
this.registerNotifications();

initializeIntervalTimer();

// If a file is already open when we activate, sometimes we don't get any notifications about visible
// or active text editors, visible ranges, or text selection. As a workaround, we trigger
// onDidChangeVisibleTextEditors here.
Expand Down
6 changes: 4 additions & 2 deletions Extension/src/LanguageServer/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,6 @@ export async function activate(): Promise<void> {

vcpkgDbPromise = initVcpkgDatabase();

void clients.ActiveClient.ready.then(() => intervalTimer = global.setInterval(onInterval, 2500));

await registerCommands(true);

vscode.tasks.onDidStartTask(() => getActiveClient().PauseCodeAnalysis());
Expand Down Expand Up @@ -366,6 +364,10 @@ function onInterval(): void {
clients.ActiveClient.onInterval();
}

export function initializeIntervalTimer(): void {
intervalTimer = global.setInterval(onInterval, 2500);
}

/**
* registered commands
*/
Expand Down