This repository was archived by the owner on Dec 23, 2021. It is now read-only.
HOTFIX: Ubuntu setup fixes #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreamah
requested review from
abmahdy,
adclements,
iennae,
isadorasophia,
markAtMicrosoft,
nasadigital,
sagarmanchanda and
smmatte
as code owners
xnkevinnguyen
added a commit
that referenced
this pull request
Apr 9, 2020
* Release Note March 10 (#251) release note modification and removed svgs from readme * ubuntu setup fixes (#281) Hotfix for Ubuntu * Serial Monitor Fix (#282) * changed release note for hotfix * Merge staging to dev * Release Note April 15 (#308) * added link to readme * pr feedback * small fix * modifications * removed gestures * adding bbc to microbit Co-authored-by: Andrea Mah <[email protected]> Co-authored-by: Vandy Liu <[email protected]> Co-authored-by: andreamah <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hotfixes for #277
The extension was not working on Ubuntu, likely because the imports were case-sensitive on Linux systems (therefore, some of the imports weren't working and causing the app to crash upon activation). The SetupService import has been fixed for this (See diff on extension.ts)
Also, while replicating the issue, I found that Ubuntu was having difficulty setting up a virtual environment on the extension side. The system was always falling back on system-wide installation. The command to fix this was added to the README.
Type of change
Please delete options that are not relevant.
Limitations:
Testing:
Testing with basic Neopixel assignment on CPX and making sure virtual env process does not fallback on system-wide imports.
Checklist:
npm run formatand passes the checks innpm run check