Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

HOTFIX: Serial Monitor Fix #282

Merged
merged 2 commits into from
Mar 28, 2020
Merged

HOTFIX: Serial Monitor Fix #282

merged 2 commits into from
Mar 28, 2020

Conversation

vandyliu
Copy link
Contributor

Description:

Same as #267

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

xnkevinnguyen
xnkevinnguyen approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vandyliu vandyliu merged commit 4a638e5 into staging Mar 28, 2020
@vandyliu vandyliu deleted the users/t-vali/serial-monitor-hotfix branch March 28, 2020 22:10
xnkevinnguyen added a commit that referenced this pull request Apr 9, 2020
@xnkevinnguyen @andreamah @vandyliu
Fix Staging-Dev conflicts (#315)
0f7054c 
* Release Note March 10 (#251)

release note modification and removed svgs from readme

* ubuntu setup fixes (#281)

Hotfix for Ubuntu

* Serial Monitor Fix (#282)

* changed release note for hotfix

* Merge staging to dev

* Release Note April 15 (#308)

* added link to readme

* pr feedback

* small fix

* modifications

* removed gestures

* adding bbc to microbit

Co-authored-by: Andrea Mah <[email protected]>
Co-authored-by: Vandy Liu <[email protected]>
Co-authored-by: andreamah <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nasadigital nasadigital nasadigital approved these changes

@xnkevinnguyen xnkevinnguyen xnkevinnguyen approved these changes

@abmahdy abmahdy Awaiting requested review from abmahdy abmahdy is a code owner

@adclements adclements Awaiting requested review from adclements adclements is a code owner

@iennae iennae Awaiting requested review from iennae

@isadorasophia isadorasophia Awaiting requested review from isadorasophia

@markAtMicrosoft markAtMicrosoft Awaiting requested review from markAtMicrosoft

@sagarmanchanda sagarmanchanda Awaiting requested review from sagarmanchanda sagarmanchanda is a code owner

@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner

@andreamah andreamah Awaiting requested review from andreamah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vandyliu @nasadigital @xnkevinnguyen