forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
CI is failing due to IFileSystem not being added into IoC container #8882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
bug
Issue identified by VS Code Team member as probable bug
regression
Bug didn't exist in a previous release
Milestone
Comments
@ericsnowcurrently This looks like a missed test update. We probably have to add |
This should be fixed with the following diff: diff --git a/src/test/debugger/envVars.test.ts b/src/test/debugger/envVars.test.ts
index 95fc1160..2e2af579 100644
--- a/src/test/debugger/envVars.test.ts
+++ b/src/test/debugger/envVars.test.ts
@@ -49,6 +49,7 @@ suite('Resolving Environment Variables when Debugging', () => {
function initializeDI() {
ioc = new UnitTestIocContainer();
ioc.registerProcessTypes();
+ ioc.registerFileSystemTypes();
ioc.registerVariableTypes();
ioc.registerMockProcess();
}
|
For validation we just need to be sure CI isn't failing for this any more. |
@ericsnowcurrently The issue is back in the latest master |
Probably from #8993 |
Submitted a PR to address this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Issue identified by VS Code Team member as probable bug
regression
Bug didn't exist in a previous release
@karthiknadig /cc
The text was updated successfully, but these errors were encountered: