Skip to content

CI is failing due to IFileSystem not being added into IoC container #8882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DonJayamanne opened this issue Dec 3, 2019 · 6 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release

Comments

@DonJayamanne
Copy link

Screen Shot 2019-12-03 at 12 30 37

@karthiknadig /cc

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug P0 triage-needed Needs assignment to the proper sub-team labels Dec 3, 2019
@luabud luabud added the triage label Dec 3, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Dec 3, 2019
@karthiknadig
Copy link
Member

@ericsnowcurrently This looks like a missed test update. We probably have to add IFileSystem to the envVars.test.ts, it should address the issue?

@karthiknadig karthiknadig added needs PR regression Bug didn't exist in a previous release and removed triage labels Dec 3, 2019
@karthiknadig karthiknadig removed their assignment Dec 3, 2019
@ericsnowcurrently
Copy link

This should be fixed with the following diff:

diff --git a/src/test/debugger/envVars.test.ts b/src/test/debugger/envVars.test.ts
index 95fc1160..2e2af579 100644
--- a/src/test/debugger/envVars.test.ts
+++ b/src/test/debugger/envVars.test.ts
@@ -49,6 +49,7 @@ suite('Resolving Environment Variables when Debugging', () => {
     function initializeDI() {
         ioc = new UnitTestIocContainer();
         ioc.registerProcessTypes();
+        ioc.registerFileSystemTypes();
         ioc.registerVariableTypes();
         ioc.registerMockProcess();
     }

@ericsnowcurrently
Copy link

For validation we just need to be sure CI isn't failing for this any more.

@ghost ghost removed the needs PR label Dec 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 17, 2019
@DonJayamanne
Copy link
Author

@ericsnowcurrently The issue is back in the latest master

@DonJayamanne DonJayamanne reopened this Dec 18, 2019
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Dec 18, 2019
@kimadeline
Copy link

Probably from #8993

@DonJayamanne
Copy link
Author

Submitted a PR to address this

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release
Projects
None yet
Development

No branches or pull requests

6 participants