Centralize fs usage. #8993
Merged
Centralize fs usage. #8993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8993 +/- ##
==========================================
+ Coverage 57.45% 57.48% +0.02%
==========================================
Files 551 550 -1
Lines 29316 29301 -15
Branches 4447 4439 -8
==========================================
Hits 16844 16844
+ Misses 11533 11518 -15
Partials 939 939
Continue to review full report at Codecov.
|
ericsnowcurrently
force-pushed
the
centralize-fs-usage
branch
from
a290ae0 to
ead41ef
Compare
rchiodo
reviewed
Dec 11, 2019
rchiodo
reviewed
Dec 11, 2019
rchiodo
reviewed
Dec 11, 2019
rchiodo
reviewed
Dec 11, 2019
rchiodo
reviewed
Dec 12, 2019
| @@ -54,6 +58,9 @@ export class FileSystem implements IFileSystem { | |||
| public readFile(filePath: string): Promise<string> { | |||
| return fs.readFile(filePath).then(buffer => buffer.toString()); | |||
There was a problem hiding this comment.
Would it be better to call fs.readFile with a encoding option? I believe in the normal fs that returns a string. Then you don't need to do the conversion.
There was a problem hiding this comment.
Yeah, that is just left over from the existing code. Regardless, I'll update it. 😄
ericsnowcurrently
force-pushed
the
centralize-fs-usage
branch
from
5f846cb to
683e42e
Compare
ericsnowcurrently
force-pushed
the
centralize-fs-usage
branch
from
a521fe0 to
5080b06
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(for #8995)
This is a partial un-revert of the recent FS changes. This change in particular only consolidates all FS-related operations to use of FileSystem objects.