Skip to content

Register disposables in importTracker.ts #14894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2020
Merged

Register disposables in importTracker.ts #14894

merged 1 commit into from
Dec 4, 2020

Conversation

joyceerhl
Copy link

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. no-changelog No news entry required labels Dec 4, 2020
@joyceerhl joyceerhl mentioned this pull request Dec 4, 2020
Merged
10 tasks
@joyceerhl joyceerhl merged commit 176b923 into main Dec 4, 2020
@joyceerhl joyceerhl deleted the register-disposables branch December 4, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@karrtikr karrtikr karrtikr approved these changes

@kimadeline kimadeline Awaiting requested review from kimadeline

Assignees

@karrtikr karrtikr

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyceerhl @karthiknadig @karrtikr