Skip to content

Issue #17037: Update text for "entire workspace" when selecting or clearing interpreters #17588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2021

Conversation

Quynhd07
Copy link

@Quynhd07 Quynhd07 commented Oct 1, 2021

Change text to "Select at workspace level" instead of "Entire workspace" when selecting or clearing interpreters in a multiroot folder scenario

@ghost
Copy link

ghost commented Oct 1, 2021

CLA assistant check
All CLA requirements met.

@karthiknadig
Copy link
Member

@Quynhd07 I am basing this to OSD branch. Since we are preparing main for release.

@karthiknadig karthiknadig changed the base branch from main to OSD October 1, 2021 19:47
@karthiknadig
Copy link
Member

@Quynhd07 Please add a news item for this change so that you get credit for it in our change logs.

@karthiknadig karthiknadig added no-changelog No news entry required skip tests Updates to tests unnecessary and removed no-changelog No news entry required labels Oct 1, 2021
@Quynhd07
Copy link
Author

Quynhd07 commented Oct 1, 2021

@karthiknadig added!

@karthiknadig
Copy link
Member

karthiknadig commented Oct 1, 2021

@Quynhd07 Can you add this text to the news file you created?

Update text for "entire workspace" when selecting or clearing interpreters.
(thanks [Quynhd07](https://github.com/Quynhd07))

@Quynhd07
Copy link
Author

Quynhd07 commented Oct 1, 2021

@karthiknadig I added it in the latest commit.

@karthiknadig karthiknadig merged commit f0ddb88 into microsoft:OSD Oct 2, 2021
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Oct 4, 2021
…ing or clearing interpreters (microsoft#17588)

* update entire workspace text

* add news item

* add news item

Co-authored-by: Quynh <[email protected]>
karthiknadig added a commit that referenced this pull request Oct 4, 2021
* Add a quick note about limited support on the web

* Tweak the description for virtual workspaces support

Closes #17600

* Update to vscode-extension-telemetry 0.4.2 (#17608)

* Update to vscode-extension-telemetry 0.4.2

* Add news

* Update to latest version of Jedi LS (#17591)

* Update to latest version of Jedi LS

* Add news

* Release candidate (#17610)

* Update version

* Update change logs

* Update notice

* Update main branch version (#17611)

* Reworded message for A/B testing in the output channel as per issue #6352 (#17584)

* Reworded message for A/B testing

* Reworded message for A/B testing

* Create 6352.md

* Added replaceAll for string prototype & unit tests (#17582)

* Added replaceAll for string prototype & unit tests

* Create 15288.md

* Bug Fix: use replaceAll for replacing separators.

* Ran prettier on updated files.

Co-authored-by: Aliva Das <[email protected]>

* Issue #17019: Reword commands in Run/Debug button in editor title (#17592)

* Reword commands in Run/Reword commands in Run/Debug button in editor title button in editor title

* fixed verbage

* update the wording in news file.

* Update news/2 Fixes/17019.md

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Update python version in brew command (#17593)

* Update python version in brew command

Previously brew command installed python version 2 (outdated). Now brew command will install python 3.

* Create 17590.md

* Rewording news file description

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Improve setting description for enabling A/B tests (#17585)

* Issue 7793 solved, rewrite discription for experiment enabling

* added news entry

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* moved news entry from 2 Fixes to 1 Enhancement

* Issue #17037: Update text for "entire workspace" when selecting or clearing interpreters  (#17588)

* update entire workspace text

* add news item

* add news item

Co-authored-by: Quynh <[email protected]>

Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Vidushi Gupta <[email protected]>
Co-authored-by: Aliva Das <[email protected]>
Co-authored-by: Aliva Das <[email protected]>
Co-authored-by: Anna Arsentieva <[email protected]>
Co-authored-by: Carolinekung2 <[email protected]>
Co-authored-by: Thi Le <[email protected]>
Co-authored-by: Quynhd07 <[email protected]>
Co-authored-by: Quynh <[email protected]>
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Oct 13, 2021
…ing or clearing interpreters (microsoft#17588)

* update entire workspace text

* add news item

* add news item

Co-authored-by: Quynh <[email protected]>
karthiknadig pushed a commit that referenced this pull request Oct 13, 2021
…earing interpreters (#17588)

* update entire workspace text

* add news item

* add news item

Co-authored-by: Quynh <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…e" when selecting or clearing interpreters (microsoft/vscode-python#17588)

* update entire workspace text

* add news item

* add news item

Co-authored-by: Quynh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants