Skip to content

Issue #17037: Update text for "entire workspace" when selecting or clearing interpreters #17588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/2 Fixes/10737.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Change text to "Select at workspace level" instead of "Entire workspace" when selecting or clearing interpreters in a multiroot folder scenario.
(Thanks [Quynh Do](https://github.com/quynhd07))
2 changes: 1 addition & 1 deletion package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"Experiments.inGroup": "User belongs to experiment group '{0}'",
"Experiments.optedOutOf": "User opted out of experiment group '{0}'",
"Interpreters.RefreshingInterpreters": "Refreshing Python Interpreters",
"Interpreters.entireWorkspace": "Entire workspace",
"Interpreters.entireWorkspace": "Select at workspace level",
"Interpreters.pythonInterpreterPath": "Python interpreter path: {0}",
"Interpreters.DiscoveringInterpreters": "Discovering Python Interpreters",
"Interpreters.condaInheritEnvMessage": "We noticed you're using a conda environment. If you are experiencing issues with this environment in the integrated terminal, we recommend that you let the Python extension change \"terminal.integrated.inheritEnv\" to false in your user settings.",
Expand Down
2 changes: 1 addition & 1 deletion src/client/common/utils/localize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export namespace Interpreters {
'Interpreters.environmentPromptMessage',
'We noticed a new virtual environment has been created. Do you want to select it for the workspace folder?',
);
export const entireWorkspace = localize('Interpreters.entireWorkspace', 'Entire workspace');
export const entireWorkspace = localize('Interpreters.entireWorkspace', 'Select at workspace level');
export const selectInterpreterTip = localize(
'Interpreters.selectInterpreterTip',
'Tip: you can change the Python interpreter used by the Python extension by clicking on the Python version in the status bar',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ suite('Reset Interpreter Command', () => {
workspace.verifyAll();
pythonPathUpdater.verifyAll();
});
test('Update entire workspace settings when there is more than one workspace folder and `Entire workspace` is selected', async () => {
test('Update entire workspace settings when there is more than one workspace folder and `Select at workspace level` is selected', async () => {
workspace.setup((w) => w.workspaceFolders).returns(() => [folder1, folder2]);
const expectedItems = [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ suite('Set Interpreter Command', () => {
workspace.verifyAll();
pythonPathUpdater.verifyAll();
});
test('Update entire workspace settings when there is more than one workspace folder and `Entire workspace` is selected', async () => {
test('Update entire workspace settings when there is more than one workspace folder and `Select at workspace level` is selected', async () => {
pythonSettings.setup((p) => p.pythonPath).returns(() => 'python');
const selectedItem: IInterpreterQuickPickItem = {
description: '',
Expand Down