-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Don't use activate from inside conda environments #5516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To test this, one simply can create a conda environment where the |
f66cbe6
to
bea3456
Compare
In contrast to virtualenv-created environments, conda environments are not activated from the inside. In constrast, the environment activation is done from the outside via the conda executable that created the environment. Fixes microsoft#4402
bea3456
to
9fdbafa
Compare
Yeah this seems right to me too. You look in the base environment first. In reply to: 489090205 [](ancestors = 489090205) |
The unit tests we already have should be verifying the interpreter path for the existing cases. Other than that, we'd like to test it on Mac/Linux/Windows with conda and non conda environments. In reply to: 487750270 [](ancestors = 487750270) |
I can try on windows. In reply to: 489131081 [](ancestors = 489131081,487750270) |
Works good on windows. In reply to: 489131165 [](ancestors = 489131165,489131081,487750270) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could a patch version be released with this please? It's a pretty big change if it makes conda environments usable again. Edit: no, it still doesn't work :( (#5539) |
In contrast to virtualenv-created environments, conda environments are not activated from the inside. In constrast, the environment activation is done from the outside via the conda executable that created the environment.
Fixes #4402
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed)