Skip to content

Fixes to FileSystem code to use bitwise operations #8966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 9, 2019

Conversation

DonJayamanne
Copy link

For #8890

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #8966 into master will increase coverage by 0.3%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #8966     +/-   ##
=========================================
+ Coverage   57.87%   58.17%   +0.3%     
=========================================
  Files         529      529             
  Lines       27727    27729      +2     
  Branches     4172     4178      +6     
=========================================
+ Hits        16046    16132     +86     
+ Misses      10784    10699     -85     
- Partials      897      898      +1
Impacted Files Coverage Δ
...interpreter/locators/services/KnownPathsService.ts 50.94% <0%> (ø) ⬆️
src/client/common/platform/fileSystem.ts 75% <60%> (+0.22%) ⬆️
src/client/common/process/proc.ts 15.55% <0%> (+0.74%) ⬆️
src/client/datascience/debugLocationTracker.ts 78.12% <0%> (+1.56%) ⬆️
src/client/linters/pydocstyle.ts 88.63% <0%> (+2.27%) ⬆️
src/client/language/characters.ts 37.14% <0%> (+2.85%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (+5.88%) ⬆️
src/client/datascience/cellFactory.ts 71.25% <0%> (+12.5%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb0ef2...bcc501d. Read the comment docs.

@DonJayamanne DonJayamanne merged commit acb59d3 into microsoft:master Dec 9, 2019
ericsnowcurrently added a commit to ericsnowcurrently/vscode-python that referenced this pull request Dec 9, 2019
ericsnowcurrently added a commit that referenced this pull request Dec 10, 2019
(for #8890)

The plan is to un-revert this stuff bit-by-bit.

* Revert "Fixes to FileSystem code to use bitwise operations (#8966)"
This reverts commit acb59d3.

* Revert "Make sure IFileSystem is registered in DI during tests. (#8902)"
This reverts commit dabd87f.

* Revert "Remove IFileSystemUtils from IOC container (#8898)"
This reverts commit 8ab93d7.

* Revert "Skip a few more tests. (#8830)"
This reverts commit d197557.

* Revert "Skip problematic tests. (#8810)"
This reverts commit c5f7766.

* Revert "Use new VS Code filesystem API. (#8307)"
This reverts commit 7cbd1c2.

* Revert "Update the code base to use IFileSystem instead of fs and fs-extra. (#7915)"
This reverts commit a23761d.
@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2019
@DonJayamanne DonJayamanne deleted the fixFSIssues branch December 17, 2019 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants