Factor out the tempfile-related code. #9455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9455 +/- ##
==========================================
+ Coverage 60.64% 60.66% +0.02%
==========================================
Files 547 548 +1
Lines 29541 29551 +10
Branches 4467 4467
==========================================
+ Hits 17914 17926 +12
+ Misses 10629 10628 -1
+ Partials 998 997 -1
Continue to review full report at Codecov.
|
ericsnowcurrently
changed the title
karrtikr
suggested changes
Jan 9, 2020
ericsnowcurrently
requested review from
karrtikr
and removed request for
karthiknadig and
kimadeline
|
Please also manually run CI :) |
karrtikr
approved these changes
Jan 15, 2020
ericsnowcurrently
force-pushed
the
fs-temp
branch
from
60682cd to
6d1bfeb
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
The failures appear to be unrelated to this PR (random timeouts). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(for #8995)
This separates the tempfile stuff from the broader "fs utils". This helps keep the code focused. It's part of what we reverted in #8970.