Skip to content

Add CI steps for mc-sgx-panic-abort #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

mc-sgx-panic-abort is a crate that that can only be built in a no_std
environment and thus can't use cargo test. Because of this
mc-sgx-panic-abort is separate from the root workspace and needs to be
explicitly called out in CI steps.

Motivation

Future Work

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Dec 15, 2022

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the size/S Small PRs label Dec 15, 2022
@nick-mobilecoin nick-mobilecoin self-assigned this Dec 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19 (bcf8290) into main (336cf09) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #19   +/-   ##
=====================================
  Coverage   9.09%   9.09%           
=====================================
  Files          2       2           
  Lines         11      11           
=====================================
  Hits           1       1           
  Misses        10      10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jcape jcape requested a review from NotGyro December 15, 2022 18:20
`mc-sgx-panic-abort` is a crate that that can only be built in a no_std
environment and thus can't use `cargo test`. Because of this
`mc-sgx-panic-abort` is separate from the root workspace and needs to be
explicitly called out in CI steps.
Copy link
Contributor

@NotGyro NotGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jan 3, 2023

✅ This pull request merged successfully as part of a Graphite job
Stack job ID: 6Sp7X9qSlxH9DNn07QXA.
See details on graphite.dev

@nick-mobilecoin nick-mobilecoin merged commit 03a17d2 into main Jan 3, 2023
@nick-mobilecoin nick-mobilecoin deleted the better-panic-abort-ci branch January 3, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Small PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants