Skip to content

Use stable rust toolchain by default #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2023
Merged

Use stable rust toolchain by default #25

merged 1 commit into from
Jan 5, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

Previously this repo was using nightly, it is now on stable.

Also added beta to some of the CI steps

Motivation

Future Work

@nick-mobilecoin nick-mobilecoin requested a review from a team as a code owner December 16, 2022 21:47
@github-actions github-actions bot added the size/M Medium-sized PRs label Dec 16, 2022
@github-actions github-actions bot requested review from jcape and samdealy December 16, 2022 21:48
@nick-mobilecoin nick-mobilecoin mentioned this pull request Dec 16, 2022
Merged
@nick-mobilecoin nick-mobilecoin mentioned this pull request Dec 16, 2022
Merged
@nick-mobilecoin
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added github_actions Pull requests that update github actions rust Pull requests that update rust code labels Dec 16, 2022
NotGyro
NotGyro approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@NotGyro NotGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, should be okay to merge.

Base automatically changed from update-ci-from-repo-template to main January 3, 2023 16:46
samdealy
samdealy approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@samdealy samdealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@nick-mobilecoin
Use stable rust toolchain by default
23d8eca 
Previously this repo was using nightly, it is now on stable.

Also added beta to some of the CI steps
@github-actions github-actions bot added size/S Small PRs and removed rust Pull requests that update rust code size/M Medium-sized PRs labels Jan 3, 2023
@nick-mobilecoin
Copy link
Collaborator Author

@NotGyro or @samdealy if one of you could do another review then this can be merged.
I had to rebase due to a conflict that came in before this,
Thanks!

@jcape jcape requested a review from NotGyro January 5, 2023 18:25
NotGyro
NotGyro approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@NotGyro NotGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still looks fine, approving the rebase

@nick-mobilecoin nick-mobilecoin merged commit a7e0d81 into main Jan 5, 2023
@nick-mobilecoin nick-mobilecoin deleted the use-stable-rust branch January 5, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotGyro NotGyro NotGyro approved these changes

@samdealy samdealy samdealy approved these changes

@jcape jcape Awaiting requested review from jcape

Assignees

@nick-mobilecoin nick-mobilecoin

Labels
github_actions Pull requests that update github actions size/S Small PRs
Projects
Blockchain Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick-mobilecoin @NotGyro @samdealy