-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CSOT: Master into csot merge #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Implement OIDC SASL mechanism in sync (mongodb#1107) JAVA-4980 * Implement OIDC auth for async (mongodb#1131) JAVA-4981 * Remove non-machine workflow (mongodb#1259) JAVA-5077 * Add Human OIDC Workflow (mongodb#1316) JAVA-5328 * OIDC Add remaining environments (azure, gcp), evergreen testing, API naming updates (mongodb#1371) JAVA-5353 JAVA-5395 JAVA-4834 JAVA-4932 Co-authored-by: Valentin Kovalenko <[email protected]>
* Remove branching code in the driver based on 3.6 version checks * Remove testing of 3.6 * Clean up tests JAVA-5294
JAVA-5356 --------- Co-authored-by: slav.babanin <[email protected]>
JAVA-5449
# Conflicts: # THIRD-PARTY-NOTICES # driver-core/src/main/com/mongodb/internal/connection/Authenticator.java # driver-core/src/main/com/mongodb/internal/connection/DefaultAuthenticator.java # driver-core/src/main/com/mongodb/internal/connection/InternalConnection.java # driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnection.java # driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnectionInitializer.java # driver-core/src/main/com/mongodb/internal/connection/SaslAuthenticator.java # driver-core/src/test/functional/com/mongodb/ClusterFixture.java # driver-core/src/test/unit/com/mongodb/internal/connection/AbstractConnectionPoolTest.java # driver-core/src/test/unit/com/mongodb/internal/connection/CommandMessageSpecification.groovy # driver-reactive-streams/src/test/functional/com/mongodb/reactivestreams/client/syncadapter/SyncMongoClient.java # driver-sync/src/test/functional/com/mongodb/client/AbstractRetryableReadsTest.java # driver-sync/src/test/functional/com/mongodb/client/unified/Entities.java
@katcharov this pull request merges master into CSOT. One of the features added to the master branch is OIDC. While I merged OIDC with CSOT, this merge does not include the OIDC spec implementation, which is covered by a separate ticket. I've added you as a reviewer to double-check if merging CSOT with the OIDC-specific changes might introduce any regression issues. I would appreciate your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see a way to review, except to perform the merge myself (which was not too substantial), and compare the results - there were not many differences, and I have noted the non-trivial ones below.
driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnection.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnection.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/unit/com/mongodb/internal/connection/CommandMessageTest.java
Outdated
Show resolved
Hide resolved
driver-core/src/test/functional/com/mongodb/ClusterFixture.java
Outdated
Show resolved
Hide resolved
…treamConnection.java Co-authored-by: Maxim Katcharov <[email protected]>
…treamConnection.java Co-authored-by: Maxim Katcharov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.