Skip to content

Add Tests: Netbox Inventory Plugin #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FragmentedPacket opened this issue Jan 11, 2020 · 4 comments
Closed

Add Tests: Netbox Inventory Plugin #56

FragmentedPacket opened this issue Jan 11, 2020 · 4 comments
Labels
Enhancement help wanted Extra attention is needed PR Required

Comments

@FragmentedPacket
Copy link
Contributor

ISSUE TYPE
  • Testing Update
SUMMARY

Need to build unit tests and possibly some integration testing for Netbox inventory plugin
@FragmentedPacket FragmentedPacket modified the milestone: v0.1.7 Feb 13, 2020
@DouglasHeriot
Copy link
Contributor

I plan to have a look at this as part of my other work on the inventory plugin.

Going to look at structuring the integration tests in such a way we can use the ansible-test tool as we do for the unit tests.
https://docs.ansible.com/ansible/latest/dev_guide/testing_integration.html

@FragmentedPacket
Copy link
Contributor Author

@DouglasHeriot Let me know how that goes. Last time I checked it doesn't allow Docker compose which is the way we're building NetBox currently for integration testing. I wouldn't spend too much time on it if it becomes too much of a burden since we're already spinning up an instance for integration tests.

@FragmentedPacket FragmentedPacket added Enhancement help wanted Extra attention is needed labels Mar 31, 2020
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 2, 2020
@DouglasHeriot
Start creating unit tests for inventory plugin netbox-community#56
64ea9de 
I've specifically started with tests for netbox-community#140 new query_filters options and refresh_url
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 2, 2020
@DouglasHeriot
Start creating unit tests for inventory plugin netbox-community#56
d2925dc 
I've specifically started with tests for netbox-community#140 new query_filters options and refresh_url
@DouglasHeriot DouglasHeriot mentioned this issue Apr 2, 2020
Merged
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 2, 2020
@DouglasHeriot
Start creating unit tests for inventory plugin netbox-community#56
0988128 
I've specifically started with tests for netbox-community#140 new query_filters options and refresh_url
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 2, 2020
@DouglasHeriot
Report code coverage of unit tests netbox-community#56
55ec1d3
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 2, 2020
@DouglasHeriot
Remove unused test fixture netbox-community#56
8093254
@DouglasHeriot DouglasHeriot mentioned this issue Apr 3, 2020
Merged
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 14, 2020
@DouglasHeriot
Start creating unit tests for inventory plugin netbox-community#56
0917d36 
I've specifically started with tests for netbox-community#140 new query_filters options and refresh_url
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 14, 2020
@DouglasHeriot
Report code coverage of unit tests netbox-community#56
9c61f67
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 14, 2020
@DouglasHeriot
Remove unused test fixture netbox-community#56
ac5c783
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 16, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
d6dea0a
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 16, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
052c93b
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 16, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
fbbdec6
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 16, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
b7ab3e8
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 16, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
33691f0
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 16, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
f987a5a
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 17, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
62e4cc3
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 17, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
b1c8e94
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 17, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
c06a2ec
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 17, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
427b6fa
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 21, 2020
@DouglasHeriot
Inventory: Start setting up integration tests (netbox-community#56)
415932f
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 21, 2020
@DouglasHeriot
Add useful hacking scripts, including to update the inventory test da…
23224eb 
…ta (netbox-community#56)

Also:
* Update .gitignore and galaxy.yml build_ignore with various development files to ignore.
* Added .editorconfig with indentation settings for .py and .yml files
DouglasHeriot added a commit to hillsong/ansible_modules that referenced this issue Apr 21, 2020
@DouglasHeriot
Add useful hacking scripts, including to update the inventory test da…
6e8beba 
…ta (netbox-community#56)

Also:
* Update .gitignore and galaxy.yml build_ignore with various development files to ignore.
* Added .editorconfig with indentation settings for .py and .yml files
@DouglasHeriot
Copy link
Contributor

We can probably close this now, implemented by #155 ?
It's not at 100% code coverage, but it's pretty solid.

@FragmentedPacket
Copy link
Contributor Author

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement help wanted Extra attention is needed PR Required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DouglasHeriot @FragmentedPacket